Skip to content

[Crashtracker] Add module path to frames #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Crashtracker] Add module path to frames #7642

wants to merge 2 commits into from

Conversation

@gleocadie
Copy link
Collaborator

@gleocadie gleocadie commented Oct 10, 2025 •
edited
Loading

Summary of changes

Add library path to the crash report.

Reason for change

The goal is to help in tagging the report.

Implementation details

collect the path and save it to the report.

Test coverage

Other details

@github-actions github-actions bot added the area:profiler Issues related to the continous-profiler label Oct 10, 2025
@pr-commenter
Copy link

pr-commenter bot commented Oct 10, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7642 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.137
  • 4 benchmarks have fewer allocations
  • 7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Faster 🎉 More allocations ⚠️

Faster 🎉 in #7642

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 1.137 14,790.91 13,010.41

More allocations ⚠️ in #7642

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 5.99 KB 6.06 KB 73 B 1.22%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.7μs 59.3ns 351ns 0 0 0 5.52 KB
master StartStopWithChild netcoreapp3.1 14.7μs 72ns 297ns 0 0 0 5.72 KB
master StartStopWithChild net472 23.2μs 126ns 726ns 1.06 0.422 0.106 5.99 KB
#7642 StartStopWithChild net6.0 10.5μs 57.2ns 339ns 0 0 0 5.51 KB
#7642 StartStopWithChild netcoreapp3.1 13μs 22.6ns 78.4ns 0 0 0 5.73 KB
#7642 StartStopWithChild net472 22.5μs 113ns 481ns 1 0.334 0.111 6.06 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 942μs 238ns 920ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 241ns 902ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.21ms 1.1μs 4.11μs 0 0 0 3.31 KB
#7642 WriteAndFlushEnrichedTraces net6.0 917μs 54.9ns 206ns 0 0 0 2.71 KB
#7642 WriteAndFlushEnrichedTraces netcoreapp3.1 1.03ms 1.38μs 5.35μs 0 0 0 2.7 KB
#7642 WriteAndFlushEnrichedTraces net472 1.21ms 287ns 1.08μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
master AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
master ObjectExtractorSimpleBody net6.0 325ns 0.165ns 0.619ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 388ns 2.18ns 14.6ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 297ns 0.0367ns 0.137ns 0.0434 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.35μs 3.23ns 12.5ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.82μs 26ns 93.6ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.61μs 1.07ns 3.7ns 0.595 0 0 3.8 KB
#7642 AllCycleSimpleBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7642 AllCycleSimpleBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7642 AllCycleSimpleBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7642 AllCycleMoreComplexBody net6.0 N/A N/A N/A NaN NaN NaN 0 b
#7642 AllCycleMoreComplexBody netcoreapp3.1 N/A N/A N/A NaN NaN NaN 0 b
#7642 AllCycleMoreComplexBody net472 N/A N/A N/A NaN NaN NaN 0 b
#7642 ObjectExtractorSimpleBody net6.0 331ns 1.8ns 10ns 0 0 0 280 B
#7642 ObjectExtractorSimpleBody netcoreapp3.1 392ns 2.22ns 14.2ns 0 0 0 272 B
#7642 ObjectExtractorSimpleBody net472 301ns 0.0431ns 0.161ns 0.044 0 0 281 B
#7642 ObjectExtractorMoreComplexBody net6.0 6.4μs 28.5ns 110ns 0 0 0 3.78 KB
#7642 ObjectExtractorMoreComplexBody netcoreapp3.1 7.84μs 30.8ns 119ns 0 0 0 3.69 KB
#7642 ObjectExtractorMoreComplexBody net472 6.68μs 6.23ns 24.1ns 0.57 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.5μs 222ns 832ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.1μs 248ns 961ns 0 0 0 32.4 KB
master EncodeArgs net472 109μs 11ns 41.1ns 4.9 0 0 32.51 KB
master EncodeLegacyArgs net6.0 146μs 87.5ns 339ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 197μs 287ns 1.11μs 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 24.2ns 90.4ns 0 0 0 2.16 KB
#7642 EncodeArgs net6.0 76.2μs 203ns 786ns 0 0 0 32.4 KB
#7642 EncodeArgs netcoreapp3.1 96.5μs 342ns 1.33μs 0 0 0 32.4 KB
#7642 EncodeArgs net472 110μs 15.9ns 61.4ns 4.94 0 0 32.51 KB
#7642 EncodeLegacyArgs net6.0 144μs 25.7ns 99.5ns 0 0 0 2.15 KB
#7642 EncodeLegacyArgs netcoreapp3.1 197μs 191ns 740ns 0 0 0 2.14 KB
#7642 EncodeLegacyArgs net472 261μs 23.2ns 90ns 0 0 0 2.17 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 398μs 143ns 537ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 807μs 10.1μs 99.9μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 429μs 45.8ns 177ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 32.5ns 126ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 211ns 789ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 308μs 41.2ns 160ns 0 0 0 2.29 KB
#7642 RunWafRealisticBenchmark net6.0 389μs 36.3ns 136ns 0 0 0 4.55 KB
#7642 RunWafRealisticBenchmark netcoreapp3.1 833μs 9.63μs 95.8μs 0 0 0 4.48 KB
#7642 RunWafRealisticBenchmark net472 428μs 65.9ns 255ns 0 0 0 4.66 KB
#7642 RunWafRealisticBenchmarkWithAttack net6.0 286μs 58.2ns 225ns 0 0 0 2.24 KB
#7642 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 300μs 73.7ns 285ns 0 0 0 2.22 KB
#7642 RunWafRealisticBenchmarkWithAttack net472 313μs 27.5ns 106ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.4μs 39.4ns 142ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 72.9μs 348ns 1.39μs 0 0 0 17.42 KB
master SendRequest net472 0.00149ns 0.000909ns 0.00352ns 0 0 0 0 b
#7642 SendRequest net6.0 61.6μs 86.8ns 313ns 0 0 0 14.52 KB
#7642 SendRequest netcoreapp3.1 72μs 55.7ns 208ns 0 0 0 17.42 KB
#7642 SendRequest net472 0.00824ns 0.00266ns 0.0103ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7642

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 0 b 73 B 73 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 0 b 47 B 47 B ∞

Fewer allocations 🎉 in #7642

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 6 B 4 B -2 B -33.33%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1 B 0 b -1 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.92ms 1.74μs 6.51μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.11ms 10.4μs 43.1μs 0 0 0 640 KB
master OriginalCharSlice net472 2.67ms 1.56μs 5.83μs 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.41ms 325ns 1.26μs 0 0 0 6 B
master OptimizedCharSlice netcoreapp3.1 1.8ms 493ns 1.91μs 0 0 0 1 B
master OptimizedCharSlice net472 2ms 483ns 1.87μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 797μs 34.9ns 135ns 0 0 0 2 B
master OptimizedCharSliceWithPool netcoreapp3.1 806μs 90.5ns 350ns 0 0 0 1 B
master OptimizedCharSliceWithPool net472 1.15ms 74.1ns 287ns 0 0 0 0 b
#7642 OriginalCharSlice net6.0 1.91ms 2.59μs 10μs 0 0 0 640.01 KB
#7642 OriginalCharSlice netcoreapp3.1 2.1ms 3.94μs 14.2μs 0 0 0 640 KB
#7642 OriginalCharSlice net472 2.62ms 442ns 1.71μs 100 0 0 641.95 KB
#7642 OptimizedCharSlice net6.0 1.45ms 1.02μs 3.94μs 0 0 0 4 B
#7642 OptimizedCharSlice netcoreapp3.1 1.73ms 169ns 656ns 0 0 0 1 B
#7642 OptimizedCharSlice net472 1.95ms 307ns 1.19μs 0 0 0 73 B
#7642 OptimizedCharSliceWithPool net6.0 833μs 59.9ns 232ns 0 0 0 2 B
#7642 OptimizedCharSliceWithPool netcoreapp3.1 811μs 160ns 620ns 0 0 0 0 b
#7642 OptimizedCharSliceWithPool net472 1.15ms 97.6ns 365ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 709μs 580ns 2.25μs 0 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 707μs 3.27μs 12.2μs 0 0 0 41.91 KB
master WriteAndFlushEnrichedTraces net472 841μs 2.62μs 10.2μs 8.33 0 0 56.42 KB
#7642 WriteAndFlushEnrichedTraces net6.0 678μs 981ns 3.8μs 0 0 0 41.72 KB
#7642 WriteAndFlushEnrichedTraces netcoreapp3.1 667μs 2.04μs 7.61μs 0 0 0 42.04 KB
#7642 WriteAndFlushEnrichedTraces net472 886μs 1.72μs 6.44μs 8.33 0 0 56.53 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.91μs 2.48ns 9.6ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.58μs 6.11ns 23.7ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.83μs 7.72ns 26.7ns 0.156 0.0142 0 987 B
#7642 ExecuteNonQuery net6.0 1.89μs 1.06ns 4.1ns 0 0 0 1.02 KB
#7642 ExecuteNonQuery netcoreapp3.1 2.54μs 8.99ns 33.6ns 0 0 0 1.02 KB
#7642 ExecuteNonQuery net472 2.93μs 2.77ns 10.7ns 0.145 0.0145 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.7μs 9.02ns 50.2ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.23μs 1.34ns 5.18ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.64μs 3.37ns 13.1ns 0.164 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.85μs 9.4ns 46ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.37μs 8.08ns 31.3ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.69μs 6.63ns 25.7ns 0.167 0 0 1.1 KB
#7642 CallElasticsearch net6.0 1.68μs 8.57ns 40.2ns 0 0 0 1.03 KB
#7642 CallElasticsearch netcoreapp3.1 2.19μs 11ns 48ns 0 0 0 1.03 KB
#7642 CallElasticsearch net472 4μs 3.03ns 11.7ns 0.158 0 0 1.04 KB
#7642 CallElasticsearchAsync net6.0 1.81μs 0.982ns 3.54ns 0 0 0 1.01 KB
#7642 CallElasticsearchAsync netcoreapp3.1 2.45μs 12.2ns 51.9ns 0 0 0 1.08 KB
#7642 CallElasticsearchAsync net472 3.71μs 2.68ns 10ns 0.168 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.8μs 8.94ns 36.9ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.53μs 6.97ns 27ns 0 0 0 952 B
master ExecuteAsync net472 2.59μs 3.03ns 11.8ns 0.142 0 0 915 B
#7642 ExecuteAsync net6.0 1.99μs 6.08ns 21.1ns 0 0 0 952 B
#7642 ExecuteAsync netcoreapp3.1 2.51μs 8.78ns 34ns 0 0 0 952 B
#7642 ExecuteAsync net472 2.68μs 2.32ns 8.98ns 0.134 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.78μs 12.6ns 48.7ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.5μs 33.1ns 128ns 0 0 0 2.9 KB
master SendAsync net472 12μs 10.4ns 40.1ns 0.484 0 0 3.18 KB
#7642 SendAsync net6.0 6.98μs 15.2ns 58.7ns 0 0 0 2.36 KB
#7642 SendAsync netcoreapp3.1 8.73μs 5.64ns 21.1ns 0 0 0 2.9 KB
#7642 SendAsync net472 12.2μs 8.06ns 30.1ns 0.485 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7642

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 294.91 KB 16.38 KB 5.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.98 KB 45.75 KB 768 B 1.71%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 258.06 KB 260.88 KB 2.82 KB 1.09%

Fewer allocations 🎉 in #7642

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 275.72 KB 273.95 KB -1.77 KB -0.64%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 44.47 KB 43.93 KB -544 B -1.22%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 46.5μs 310ns 2.96μs 0 0 0 44.98 KB
master StringConcatBenchmark netcoreapp3.1 47.8μs 304ns 2.95μs 0 0 0 44.47 KB
master StringConcatBenchmark net472 57.3μs 155ns 579ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 488μs 2.18μs 7.88μs 0 0 0 275.72 KB
master StringConcatAspectBenchmark netcoreapp3.1 510μs 2.34μs 9.94μs 0 0 0 258.06 KB
master StringConcatAspectBenchmark net472 401μs 2.05μs 10.1μs 0 0 0 278.53 KB
#7642 StringConcatBenchmark net6.0 45.6μs 238ns 1.23μs 0 0 0 45.75 KB
#7642 StringConcatBenchmark netcoreapp3.1 47μs 248ns 1.24μs 0 0 0 43.93 KB
#7642 StringConcatBenchmark net472 58μs 198ns 714ns 0 0 0 65.54 KB
#7642 StringConcatAspectBenchmark net6.0 477μs 1.61μs 7.2μs 0 0 0 273.95 KB
#7642 StringConcatAspectBenchmark netcoreapp3.1 532μs 2.23μs 8.36μs 0 0 0 260.88 KB
#7642 StringConcatAspectBenchmark net472 404μs 2μs 8.25μs 0 0 0 294.91 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.597ns 2.31ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.72μs 12.6ns 47.1ns 0 0 0 1.7 KB
master EnrichedLog net472 3.85μs 2.8ns 10.9ns 0.249 0 0 1.64 KB
#7642 EnrichedLog net6.0 2.64μs 13.5ns 61.9ns 0 0 0 1.7 KB
#7642 EnrichedLog netcoreapp3.1 3.58μs 18.2ns 83.6ns 0 0 0 1.7 KB
#7642 EnrichedLog net472 3.88μs 3.26ns 12.6ns 0.253 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 50ns 194ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 126μs 167ns 602ns 0 0 0 4.31 KB
master EnrichedLog net472 165μs 41.5ns 144ns 0 0 0 4.51 KB
#7642 EnrichedLog net6.0 123μs 44.3ns 153ns 0 0 0 4.31 KB
#7642 EnrichedLog netcoreapp3.1 129μs 203ns 704ns 0 0 0 4.31 KB
#7642 EnrichedLog net472 168μs 220ns 851ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.87μs 23.1ns 89.5ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.85μs 25.1ns 93.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.83μs 4.28ns 16.6ns 0.312 0 0 2.08 KB
#7642 EnrichedLog net6.0 4.95μs 3.55ns 12.8ns 0 0 0 2.26 KB
#7642 EnrichedLog netcoreapp3.1 6.84μs 21.7ns 81.3ns 0 0 0 2.26 KB
#7642 EnrichedLog net472 7.54μs 2.8ns 10.5ns 0.302 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.97μs 9.65ns 39.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.63μs 1.94ns 7.53ns 0 0 0 1.2 KB
master SendReceive net472 3.17μs 2.39ns 9.25ns 0.189 0 0 1.2 KB
#7642 SendReceive net6.0 1.98μs 0.532ns 1.99ns 0 0 0 1.2 KB
#7642 SendReceive netcoreapp3.1 2.63μs 7.39ns 28.6ns 0 0 0 1.2 KB
#7642 SendReceive net472 2.99μs 1.57ns 6.07ns 0.18 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.27μs 14.6ns 54.7ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.66μs 17.7ns 68.5ns 0 0 0 1.63 KB
master EnrichedLog net472 6.59μs 6.54ns 25.3ns 0.296 0 0 2.03 KB
#7642 EnrichedLog net6.0 4.3μs 12.9ns 49.9ns 0 0 0 1.58 KB
#7642 EnrichedLog netcoreapp3.1 5.63μs 14.9ns 55.7ns 0 0 0 1.63 KB
#7642 EnrichedLog net472 6.59μs 6.01ns 23.3ns 0.295 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 779ns 0.136ns 0.525ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 994ns 0.221ns 0.766ns 0 0 0 576 B
master StartFinishSpan net472 951ns 0.0688ns 0.248ns 0.0911 0 0 578 B
master StartFinishScope net6.0 933ns 4.87ns 24.4ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.21μs 5.45ns 21.1ns 0 0 0 696 B
master StartFinishScope net472 1.15μs 0.757ns 2.93ns 0.103 0 0 658 B
#7642 StartFinishSpan net6.0 767ns 0.197ns 0.711ns 0 0 0 576 B
#7642 StartFinishSpan netcoreapp3.1 977ns 5.24ns 30.1ns 0 0 0 576 B
#7642 StartFinishSpan net472 947ns 0.101ns 0.379ns 0.0901 0 0 578 B
#7642 StartFinishScope net6.0 912ns 4.22ns 16.9ns 0 0 0 696 B
#7642 StartFinishScope netcoreapp3.1 1.18μs 5.98ns 27.4ns 0 0 0 697 B
#7642 StartFinishScope net472 1.14μs 0.15ns 0.582ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.06μs 5.66ns 28.3ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.4μs 6.03ns 23.3ns 0 0 0 696 B
master RunOnMethodBegin net472 1.42μs 0.566ns 2.04ns 0.0995 0 0 658 B
#7642 RunOnMethodBegin net6.0 1.08μs 5.53ns 24.1ns 0 0 0 696 B
#7642 RunOnMethodBegin netcoreapp3.1 1.42μs 7.15ns 26.8ns 0 0 0 696 B
#7642 RunOnMethodBegin net472 1.48μs 1.02ns 3.93ns 0.103 0 0 658 B

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Oct 10, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (72ms)  : 70, 73
     .   : milestone, 72,
    master - mean (71ms)  : 71, 72
     .   : milestone, 71,

    section Baseline
    This PR (7642) - mean (68ms)  : 66, 69
     .   : milestone, 68,
    master - mean (68ms)  : 67, 69
     .   : milestone, 68,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (1,040ms)  : 1007, 1073
     .   : milestone, 1040,
    master - mean (1,041ms)  : 1010, 1072
     .   : milestone, 1041,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (106ms)  : 105, 107
     .   : milestone, 106,

    section Baseline
    This PR (7642) - mean (106ms)  : 103, 108
     .   : milestone, 106,
    master - mean (105ms)  : 102, 108
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (746ms)  : 729, 764
     .   : milestone, 746,
    master - mean (749ms)  : 726, 772
     .   : milestone, 749,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 94
     .   : milestone, 94,

    section Baseline
    This PR (7642) - mean (93ms)  : 91, 96
     .   : milestone, 93,
    master - mean (93ms)  : 91, 96
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (707ms)  : 674, 740
     .   : milestone, 707,
    master - mean (708ms)  : 673, 744
     .   : milestone, 708,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (92ms)  : 91, 93
     .   : milestone, 92,
    master - mean (92ms)  : 91, 94
     .   : milestone, 92,

    section Baseline
    This PR (7642) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (658ms)  : 644, 672
     .   : milestone, 658,
    master - mean (662ms)  : 648, 677
     .   : milestone, 662,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (197ms)  : 193, 201
     .   : milestone, 197,
    master - mean (196ms)  : 193, 200
     .   : milestone, 196,

    section Baseline
    This PR (7642) - mean (193ms)  : 189, 196
     .   : milestone, 193,
    master - mean (193ms)  : 189, 196
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (1,166ms)  : 1097, 1234
     .   : milestone, 1166,
    master - mean (1,164ms)  : 1099, 1229
     .   : milestone, 1164,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (278ms)  : 272, 285
     .   : milestone, 278,

    section Baseline
    This PR (7642) - mean (276ms)  : 271, 281
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (940ms)  : 899, 982
     .   : milestone, 940,
    master - mean (946ms)  : 908, 984
     .   : milestone, 946,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (268ms)  : 265, 272
     .   : milestone, 268,
    master - mean (269ms)  : 266, 272
     .   : milestone, 269,

    section Baseline
    This PR (7642) - mean (269ms)  : 262, 275
     .   : milestone, 269,
    master - mean (269ms)  : 264, 274
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (930ms)  : 875, 985
     .   : milestone, 930,
    master - mean (932ms)  : 882, 982
     .   : milestone, 932,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7642) - mean (268ms)  : 264, 271
     .   : milestone, 268,
    master - mean (269ms)  : 261, 277
     .   : milestone, 269,

    section Baseline
    This PR (7642) - mean (268ms)  : 264, 272
     .   : milestone, 268,
    master - mean (268ms)  : 263, 272
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7642) - mean (855ms)  : 832, 878
     .   : milestone, 855,
    master - mean (851ms)  : 829, 872
     .   : milestone, 851,
Loading

@gleocadie gleocadie marked this pull request as ready for review October 14, 2025 09:43
@gleocadie gleocadie requested review from a team as code owners October 14, 2025 09:43
@datadog-official

This comment has been minimized.

Sign in to view
@gleocadie gleocadie force-pushed the gleocadie/add-module-path-to-crash-report branch 2 times, most recently from ef42d0a to 5e300de Compare October 14, 2025 16:11
link04 pushed a commit to link04/dd-trace-dotnet that referenced this pull request Oct 14, 2025
@andrewlock @lucaspimentel
More cleanup in native loader code (DataDog#7475)
9e2737a 
## Summary of changes

- Cleanup of some of the native loader code
- Add `createdump` to the exclude list

## Reason for change

Various minor things that have been bugging me for a while.

## Implementation details

- Remove `default_exclude_assemblies` from the native tracer as it's no
longer used (after DataDog#7642)
- Remove `default_exclude_assemblies` to `default_exclude_processes` as
it was named incorrectly!
- Move environment variables that were in `util.h` into the
`EnvironmentVariables` type that's designed for this (and remove
duplicates)
- Rename `EnvironmentVariables.h` to `environment.h` for consistency
with the majoring of the native loader code + native tracer. Use snake
casing instead of PascalCasing
- Move constants out of `util.h` into `constants.h` to avoid cluttering
it
- Add `createdump` to the process exclude list (I noticed we apparently
instrument the `createdump` calls themselves in our CI!)

## Test coverage

Covered by existing

## Other details

Commit-by-commit review is easiest, as they're all small self-contained
updates!


<!--  ⚠️ Note:

Where possible, please obtain 2 approvals prior to merging. Unless
CODEOWNERS specifies otherwise, for external teams it is typically best
to have one review from a team member, and one review from apm-dotnet.
Trivial changes do not require 2 reviews.

MergeQueue is NOT enabled in this repository. If you have write access
to the repo, the PR has 1-2 approvals (see above), and all of the
required checks have passed, you can use the Squash and Merge button to
merge the PR. If you don't have write access, or you need help, reach
out in the #apm-dotnet channel in Slack.
-->

---------

Co-authored-by: Lucas Pimentel <[email protected]>
@gleocadie gleocadie force-pushed the gleocadie/add-module-path-to-crash-report branch from 5e300de to c52279f Compare October 27, 2025 07:45
@gleocadie gleocadie force-pushed the gleocadie/add-module-path-to-crash-report branch from c52279f to 8e92f99 Compare October 29, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:crashtracking area:profiler Issues related to the continous-profiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gleocadie